Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trajectories test feedback #4595

Merged
merged 14 commits into from
Jan 14, 2024

Conversation

nomadscientist
Copy link
Collaborator

These are some suggested changes based on testing this tutorial: https://training.galaxyproject.org/training-material/topics/single-cell/tutorials/scrna-case_trajectories/tutorial.html#conclusion

It's an awesome tutorial, great work!

@nomadscientist nomadscientist self-assigned this Dec 15, 2023
@nomadscientist nomadscientist requested a review from a team as a code owner December 15, 2023 00:21
@nomadscientist nomadscientist removed their assignment Dec 15, 2023
- 10x
- transcriptomics

contributions:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could add yourself to testing

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured I was already on authorship so didn't make sense to

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think authorship + editing are mutually exclusive, one is definitely the larger contribution, but testing feels like a separate axis? At least to my feeling, it says someone sat down and tested this, and reported bugs, as a separate activity to text editing/authorship"

MarisaJL
MarisaJL previously approved these changes Dec 20, 2023
Copy link
Collaborator

@MarisaJL MarisaJL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with these changes

@nomadscientist nomadscientist merged commit 08cb3b1 into galaxyproject:main Jan 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants